Changes between Version 19 and Version 20 of Internal/NewNodeAgent

Timestamp:

Feb 13, 2015, 1:49:08 AM (10 years ago)

Author:

ssugrim

Comment:

—

Internal/NewNodeAgent

@@ -7 +7 @@
  * cocaine refrence [https://github.com/thoughtbot/cocaine here]
  * yaml?
+ * timeout
 
 
@@ -236 +237 @@
 
 added UML diagram of driver class layout. Followed UML guidelines from [http://www.ibm.com/developerworks/rational/library/content/RationalEdge/sep04/bell/ here] and [http://aviadezra.blogspot.com/2009/05/uml-association-aggregation-composition.html here]. Note Diamond = composotion, and arrow = parent.
+
+wired Class mostly implemented. A few notable large code changes:
+ * Most of the checks to @devName were switched to checks against @isActive since you can't (or shouldn't) be able to activate with out knowing your devName. Check to activate is more proper since it means ready to be configured instead of I know my name (but those are almost equivalent conditions). The noteable accpetion is of course the new wired class where the name is always known, but a call to activate (for other checks and population of config hash) has not been made.
+ * All calls to @@some_line.run have been wrapped into a Timeout::timeout(@cmdTimeout){} block. If @cmdTimeout number of seconds passes, the block emits a Timeout::Error exception. I then catch this expception and re-raise it with some context info (the command I was running). Ultimately this exception will be caught in Agent commands and used as info for a "command failed" message that is sent back console. 
+
+It should be noted that AgentCommands::configure should catch all exceptions and log them (or at least like standard error, but something pretty wide).  This way the nodeagent never dies. And since every command should now timeout, the agent should never lock up (for ever).
+